RFC Function Contracts #2620
RFC Function Contracts #2620
Conversation
There was a problem hiding this comment.
I like this structure much better! Thanks.
I haven't finished reviewing it yet. I'll keep looking at it later today.
I do have two things I would like to discuss:
- Our previous contract implementation uses
#[kani::modifies]instead ofassigns. I like that better. - I think it should be up to the user to verify their contracts. We shouldn't enforce it inside Kani, especially for contracts defined in a dependency.
Co-authored-by: Celina G. Val <celinval@amazon.com>
Co-authored-by: Celina G. Val <celinval@amazon.com>
There was a problem hiding this comment.
The "User Experience" section is structured in a way that makes it a little hard-to-follow. It seems to me that you're trying to tackle three problems at once: specification, checking and replacement. Maybe each could have their own subsection instead of being itemized?
There's a similar issue with "Rationale and alternatives" and "Future possibilities", although I haven't carefully read them yet.
Co-authored-by: Celina G. Val <celinval@amazon.com> Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @JustusAdam , it's looking great! Only a couple technical comments, the rest are more related to writing.
Co-authored-by: Celina G. Val <celinval@amazon.com> Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Co-authored-by: Celina G. Val <celinval@amazon.com>
|
BTW, please wait for a second approval before merging. Thanks! |
There was a problem hiding this comment.
Thanks @JustusAdam ! Please take care of unresolved comments before merging.
I'm going to wait for @remi-delmas-3000 to give it another look because there are some unresolved comments before merging. |
Co-authored-by: Celina G. Val <celinval@amazon.com> Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Rendered
Proposes the addition of function contracts and mechanisms to check them and use them as modular abstractions.