Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(api): add refiller index goroutine for search index #907

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

almostinf
Copy link
Member

Refiller goroutine

Repopulates the search index thereby removing memory leaks that appeared when filling, updating and searching the index. Also removed memory leaks in tests and refactoring

TODO: add tests for refiller

@almostinf almostinf requested a review from a team as a code owner September 6, 2023 11:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #907 (ba36990) into master (9d54d2f) will decrease coverage by 0.56%.
Report is 3 commits behind head on master.
The diff coverage is 34.28%.

❗ Current head ba36990 differs from pull request most recent head f15b5f8. Consider uploading reports for the commit f15b5f8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   68.93%   68.38%   -0.56%     
==========================================
  Files         195      197       +2     
  Lines       10866    11050     +184     
==========================================
+ Hits         7491     7556      +65     
- Misses       2934     3050     +116     
- Partials      441      444       +3     
Files Changed Coverage Δ
cmd/api/main.go 0.00% <0.00%> (ø)
database/redis/subscription.go 75.36% <0.00%> (-2.64%) ⬇️
database/redis/trigger.go 72.46% <0.00%> (-6.28%) ⬇️
metric_source/prometheus/prometheus.go 46.66% <ø> (ø)
index/batch.go 57.01% <6.66%> (-30.83%) ⬇️
index/metrics.go 51.85% <20.00%> (-18.74%) ⬇️
index/sweepper.go 54.54% <20.00%> (-10.17%) ⬇️
index/actualizer.go 66.66% <27.27%> (-3.65%) ⬇️
index/refiller.go 31.42% <31.42%> (ø)
cmd/api/trigger_stats.go 35.71% <35.71%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@github-actions
Copy link

Build and push Docker images with tag: feature-add-refiller-goroutine.2023-09-12.856b735

2 similar comments
@github-actions
Copy link

Build and push Docker images with tag: feature-add-refiller-goroutine.2023-09-12.856b735

@github-actions
Copy link

Build and push Docker images with tag: feature-add-refiller-goroutine.2023-09-12.856b735

@@ -84,6 +84,7 @@ func main() {
databaseSettings := applicationConfig.Redis.GetSettings()
notificationHistorySettings := applicationConfig.NotificationHistory.GetSettings()
database := redis.NewDatabase(logger, databaseSettings, notificationHistorySettings, redis.API)
database.Flush()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ой

@almostinf almostinf marked this pull request as draft November 10, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants