Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-overwrite IT fails #136

Closed
lasselindqvist opened this issue Mar 25, 2020 · 4 comments
Closed

no-overwrite IT fails #136

lasselindqvist opened this issue Mar 25, 2020 · 4 comments

Comments

@lasselindqvist
Copy link
Collaborator

no-overwrite IT fails. This blocks the release until fixed.

    [INFO] Building: no-overwrite\pom.xml
    [INFO] run script verify.groovy
    [INFO] ..FAILED (6.2 s)
    [INFO]   The post-build script did not succeed. assert System.currentTimeMil
lis() - flattendPom.lastModified() > 30*1000
                  |                   | |           |              |   |
                  1585152197487       94|           1585152197393  |   30000
                                        |                          false
flatten-maven-plugin\target\it\no-overwrite\.flattened-pom.xml
@olamy
Copy link
Member

olamy commented Mar 26, 2020

and doesn't fail in travis :(

olamy added a commit to olamy/flatten-maven-plugin that referenced this issue Mar 27, 2020
….3 and so update travis etc... bump parent pom so we can now use 1.7

Signed-off-by: olivier lamy <olamy@apache.org>
@olamy
Copy link
Member

olamy commented Mar 27, 2020

fixed the issue. You may using maven 3.6 and travis was using 3.5.4
some change in writing pom :)
now
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0">

before
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0">

1 byte difference :)

@stephaniewang526
Copy link
Contributor

Seems like this fix is causing issues in Maven version before 3.6.3.

We tested in 3.6. and 3.5.2 and they both failed because of "https".

This seems to only work for 3.6.3.

We could upgrade our Maven version but should this be fixed for versions lower than 3.6.3?

@nuoyuyang @lasselindqvist

@olamy
Copy link
Member

olamy commented May 19, 2020

@stephaniewang526 well If you have bandwidth to add a test if <3.6.3 then http let's do it
But I would consider this as very very very minor as it's only for testing purpose and maven 3.6.3 is right using https rather than http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants