You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're trying to implement flatten plugin in GCP cloud clients and we ran into the following issue where the dependency version in <profile> is not correctly added when the dependency is managed by <dependencyManagement>. Here's a common scenario found in numerous GCP clients:
In the parent pom (below example taken from google-cloud-pubsub-parent):
…in profile which is managed by <dependencyManagement> (#155)
* Fixes#145, #148 add codes to parse the <version> for the dependency in profile which is managed by <dependencyManagement>
* remove redundant code
* add empty line at the end of files
* remove profile-with-deps-inherit-parent-depMgmt-ci test
* consolidate two blocks of code change into createCleanPom method
* restore import change
* restore import change
* add test profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-oss
* change test profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-oss to profile-with-deps-inherit-parent-depMgmt-flatten-dep-all-oss-bom
* code style fix
* fix indents and licenses declaration in verify.groovy
* set scope as compile and optional as false if not specified
* fix scope and optional - code style
Co-authored-by: yangnuoyu <yangnuoyu@penguin>
We're trying to implement flatten plugin in GCP cloud clients and we ran into the following issue where the dependency version in
<profile>
is not correctly added when the dependency is managed by<dependencyManagement>
. Here's a common scenario found in numerous GCP clients:In the parent pom (below example taken from
google-cloud-pubsub-parent
):In the cloud client pom (below example taken from
google-cloud-pubsub
)Adding flatten plugin to the cloud client, in this instance, results in an invalid pom file since
<version>
for javax-annotaions-api will be missing.Does anyone know if there's an existing configuration change that could resolve this issue? Or if this should be a new fix/feature?
We're currently addressing this issue by manually adding
<version>
in<profile>
as such:However, this is not ideal since it is manual there fore we cannot go GA with the current limitation -- please opine.
Thank you.
cc @saturnism
The text was updated successfully, but these errors were encountered: