Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #140 by separating no-overwritten test into two basing on maven version #154

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

yangnuoyu
Copy link
Contributor

@elharo
Copy link
Contributor

elharo commented May 26, 2020

INFO] -------------------------------------------------

[ERROR] The following builds failed:

[ERROR] * no-overwrite-3.6.2-before/pom.xml

[INFO] -------------------------------------------------

@stephaniewang526
Copy link
Contributor

LGTM

@stephaniewang526
Copy link
Contributor

@olamy PTAL

@olamy olamy merged commit 6b5779f into mojohaus:master Jun 2, 2020
@famod
Copy link
Contributor

famod commented Jun 7, 2020

This PR assumes that one uses mvnw, but I don't do so. So now I am getting:

The post-build script did not succeed. Cannot run program "./mvnw": CreateProcess error=193, %1 ist keine zulässige Win32-Anwendung

The second part is something like this in English:

%1 is no valid Win32-application

@yangnuoyu yangnuoyu deleted the pr-no-overwritten-test branch June 10, 2020 16:33
@hboutemy
Copy link
Member

@yangnuoyu @stephaniewang526 I don't understand the difference between the 2 ITs: what is different before and after Maven 3.6.3, please?

@hboutemy hboutemy linked an issue Feb 28, 2021 that may be closed by this pull request
hboutemy added a commit that referenced this pull request Feb 28, 2021
@hboutemy
Copy link
Member

ok, I finally found the http vs https xsd url in .flattened-pom.xml

ITs made more simple & reliable by using Maven version selection in invoker.properties https://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#invokerPropertiesFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-overwrite\pom.xml IT fails in some environments Avoid rewriting the flattened pom if nothing has changed
6 participants