Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display-parent-updates should support allowMajorUpdates, allowMinorUpdates and related parameters #1016

Closed
cachescrubber opened this issue Oct 23, 2023 · 2 comments · Fixed by #1017
Closed

display-parent-updates should support allowMajorUpdates, allowMinorUpdates and related parameters #1016

cachescrubber opened this issue Oct 23, 2023 · 2 comments · Fixed by #1017
Labels
enhancement
Milestone
2.16.2

Comments

@cachescrubber
Copy link
Contributor

Since #966 (2.16.0) most display-*-updates and update-* goals consistently support a set of common parameters to narrow the scope of used dependencies (allowMajorUpdates, allowMinorUpdates, allowIncrementalUpdates, ...) However, display-parent-updates does not.

If you agree I'm happy to contribute a PR to make sure display-parent-updates accepts the same parameters as update-parent.
@slawekjaranowski
Copy link
Member

PR are always welcome 😄

Please pay attention that we have:

  • versions:update-parent
  • versions:display-parent-updates
  • versions:parent-updates-report

Agree available options should be similar.

cachescrubber added a commit to cachescrubber/versions that referenced this issue Oct 23, 2023
@cachescrubber
Resolves mojohaus#1016 - Align update-parent and display-parent-update
5b5f97a
@cachescrubber cachescrubber mentioned this issue Oct 23, 2023
Merged
@cachescrubber
Copy link
Contributor Author

Hi @slawekjaranowski , please have a look at #1017

From the *-report goals, none is currently supporting the allMajor/Minor parameter.

@slawekjaranowski slawekjaranowski added this to the next-release milestone Nov 13, 2023
olamy pushed a commit that referenced this issue Nov 16, 2023
@cachescrubber
Align update-parent and display-parent-update (#1017)
e56c8c4 
* Resolves #1016 - Align update-parent and display-parent-update

* Introduce DisplayParentUpdatesMojoOutputTest

* use SegmentUtils.determineUnchangedSegment

* Align DisplayParentUpdatesMojoTest and UpdateParentMojoTest

* Apply formatting rules

* update javadoc since annotation to 2.17.0 for newly introduced properties

* Align variable name between DisplayParentUpdatesMojo and UpdateParentMojo

* Align skipResolution && isBlank(parentVersion)

* Use Optional in favor of ternary operator
@cachescrubber cachescrubber mentioned this issue Nov 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.16.2
Development

Successfully merging a pull request may close this issue.

Align update-parent and display-parent-update cachescrubber/versions
2 participants
@slawekjaranowski @cachescrubber