Provide "god reload" command to stop watchers that are no longer defined #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to see a few tests for this first. Otherwise, I like it, but honestly I'd rather it replace load and have the same behavior as currently if you don't specify an optional 2nd param. Having two different reload mechanisms is confusing. |
|
I like your idea of making it an optional second parameter. If you don't specify anything, it does the current behavior of |
hello-doodle
added a commit
to hello-doodle/god
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new command:
god reload <file> <action>for reloading a file while cleaning up watchers that are no longer defined.I have decided to propose this route instead of changing the behavior of
god load(as I did in #45) to not be surprising until we have a chance to use this more.To stop all watchers that are no longer defined:
To just quit watching watchers that are no longer defined: