set frontier_log to last log that decodes and break #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217
What important points reviewers should know?
initial suggestion
The previous loop set
frontier_log
to the last log thatis_some
(after atry_to
decode attempt) innotification.header.digest.logs
. If there are no logs that areis_some
, then it is None.The new loop starts from the end and goes backwards; it sets
frontier_log
to the lastlog
thatis_some
and then breaks from the loop instead of going over all the logs every time. Worst case is still the same, but, if not worst case, this is better because it breaks early.Checklist
This is a small change to how the logic is expressed, but doesn't change the underlying logic.