Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev-service import queue #266

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

JoshOrndorff
Copy link
Contributor

This PR corrects a mistake that I introduced in #260 . I thought that the only difference between the cumulus import queue and the manualseal import queue was that the cumulus one checked the inherents. I reasoned that therefore the cumulus one was strictly better.

However, I was wrong. The cumulus import queue does not mark any imported blocks as best. This leads to endless chain forking in a dev-service-based network.

This PR fixes it by constructing a manual seal import queue in the dev service only.

Longer term I may modify the manual seal import queue in Substrate so that it does check inehrents, and marking blocks as best is optional. Then cumulus could use the manual seal import queue. For now this fix should work.

Checklist

  • ❌ Does it require a purge of the network?
  • ❌ You bumped the runtime version if there are breaking changes in the runtime ?
  • ❌ Does it require changes in documentation/tutorials ?

@JoshOrndorff JoshOrndorff merged commit a9dbefc into master Mar 5, 2021
@JoshOrndorff JoshOrndorff deleted the joshy-fix-dev-import-queue branch March 5, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants