Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a mistake that I introduced in #260 . I thought that the only difference between the cumulus import queue and the manualseal import queue was that the cumulus one checked the inherents. I reasoned that therefore the cumulus one was strictly better.
However, I was wrong. The cumulus import queue does not mark any imported blocks as best. This leads to endless chain forking in a dev-service-based network.
This PR fixes it by constructing a manual seal import queue in the dev service only.
Longer term I may modify the manual seal import queue in Substrate so that it does check inehrents, and marking blocks as best is optional. Then cumulus could use the manual seal import queue. For now this fix should work.
Checklist