Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript API for runtime-3100 #2896

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Upgrade typescript API for runtime-3100 #2896

merged 2 commits into from
Aug 6, 2024

Conversation

noandrea
Copy link
Collaborator

@noandrea noandrea commented Aug 1, 2024

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@noandrea noandrea requested review from a team, pLabarta and ahmadkaouk and removed request for a team August 1, 2024 13:16
@noandrea noandrea added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Aug 1, 2024
Copy link
Contributor

@timbrinded timbrinded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Coverage Report

@@                  Coverage Diff                   @@
##           master   typescript-api-3100     +/-   ##
======================================================
  Coverage   80.97%                80.97%   0.00%     
+ Files         281                   282      +1     
+ Lines       81575                 81590     +15     
======================================================
+ Hits        66054                 66065     +11     
+ Misses      15521                 15525      +4     
Files Changed Coverage

Coverage generated Fri Aug 2 15:07:15 UTC 2024

@RomarQ RomarQ merged commit 41ebb79 into master Aug 6, 2024
37 checks passed
@RomarQ RomarQ deleted the typescript-api-3100 branch August 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants