Skip to content

Commit

Permalink
Deprecate dmp-queue pallet (paritytech#4475)
Browse files Browse the repository at this point in the history
`cumulus-pallet-dmp-queue` is not needed anymore since
paritytech#1246.

The only logic that remains in the pallet is a lazy migration in the
[`on_idle`](https://github.com/paritytech/polkadot-sdk/blob/8d62c13b2541920c37fb9d9ca733fcce91e96573/cumulus/pallets/dmp-queue/src/lib.rs#L158)
hook.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
  • Loading branch information
ggwpez authored and TarekkMA committed Aug 2, 2024
1 parent 7cf41f4 commit 2a38895
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cumulus/pallets/dmp-queue/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
//! from the runtime once `Completed` was emitted.

#![cfg_attr(not(feature = "std"), no_std)]
#![allow(deprecated)] // The pallet itself is deprecated.

use migration::*;
pub use pallet::*;
Expand All @@ -38,6 +39,9 @@ pub type MaxDmpMessageLenOf<T> =
<<T as Config>::DmpSink as frame_support::traits::HandleMessage>::MaxMessageLen;

#[frame_support::pallet]
#[deprecated(
note = "`cumulus-pallet-dmp-queue` will be removed after November 2024. It can be removed once its lazy migration completed. See <https://github.com/paritytech/polkadot-sdk/pull/1246>."
)]
pub mod pallet {
use super::*;
use frame_support::{pallet_prelude::*, traits::HandleMessage, weights::WeightMeter};
Expand Down
10 changes: 10 additions & 0 deletions prdoc/pr_4475.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
title: "Deprecate dmp-queue pallet"

doc:
- audience: Runtime Dev
description: |
Schedule the DMP queue pallet for deletion. It is not needed anymore sine https://github.com/paritytech/polkadot-sdk/pull/1246.

crates:
- name: cumulus-pallet-dmp-queue
bump: minor

0 comments on commit 2a38895

Please sign in to comment.