Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demostrate snapshot testing #930

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

lijunchen
Copy link
Contributor

This PR demonstrates the usage of snapshot testing.

Currently, three functions are provided:

  • @test.T::write(self: T, obj: Show) -> Unit: writes a showable object to T's internal buffer.
  • @test.T::writeln(self: T, obj: Show) -> Unit: writes a showable object followed by a newline to T's internal buffer.
  • @test.T::snapshot!(self: T, ~filename: String): writes the contents of the internal buffer to a file, which will be placed inside the __snapshot__ directory within the current package.
    • ⚠️ Ensure that the filename do not conflict with existing ones.

For example, the following test case is located in test/test_test.mbt, after running moon test -u, the it.snapshot!(filename="001.txt") call will write the buffer contents to test/__snapshot__/001.txt.

test "test snapshot testing" (it : @test.T) {
  it.write("test")
  it.write(" ")
  it.write("snapshot")
  it.write(" ")
  it.writeln("testing")
  it.write("测试")
  it.write("快照")
  it.writeln("测试")
  it.snapshot!(filename="001.txt")
}

Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lijunchen lijunchen force-pushed the lijunchen/demo-snapshot-testing branch from fd32ddf to 807f667 Compare August 28, 2024 06:49
@coveralls
Copy link
Collaborator

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 3069

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 83.755%

Totals Coverage Status
Change from base Build 3068: 0.06%
Covered Lines: 3944
Relevant Lines: 4709

💛 - Coveralls

@lijunchen lijunchen force-pushed the lijunchen/demo-snapshot-testing branch from 5d18290 to e36478c Compare September 9, 2024 07:03
Copy link

  1. Incorrect Year in Copyright Notice:
    The copyright notice states "Copyright 2024," which is likely a typo or placeholder as it is beyond the current year. Ensure this is updated to the correct year or remains a placeholder until the appropriate year is reached.

  2. Inconsistent File Naming:
    The filename test_test.mbt appears to be repetitive. Consider renaming it to something more descriptive or concise to avoid confusion, especially in a test directory where clarity is crucial.

  3. Snapshot Filename Hardcoding:
    In the test code, the snapshot filename is hardcoded as "001.txt". This might not scale well if multiple snapshots are needed, and it could lead to overwriting issues. Consider using a dynamic or incremental naming scheme for snapshot files to prevent accidental overwrites and to manage multiple snapshots effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants