Tests reserve transfers #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
a0-pleasereview
girazoki
added
the
D3-trivial
girazoki
changed the title
Coverage Report@@ Coverage Diff @@
## master girazoki-tests-reserve-transfers +/- ##
====================================================================
+ Coverage 64.77% 65.08% +0.31%
- Files 66 64 -2
- Lines 9775 9515 -260
====================================================================
- Hits 6331 6192 -139
- Misses 3444 3323 -121
|
girazoki
changed the title
girazoki
added
the
B0-silent
Agusrodri
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Looks good! Regarding the tests for delivery fees, I think it's fine if we add them in another PR.
Edit: I see you already opened #479, so we could implement those tests there or also in a separate PR would be fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests regarding the
transfer_assetsextrinsic inPolkadotXcm. I cherry-picked paritytech/polkadot-sdk#3450. so that delivery fees work in the latest-case