Add support for SDK 50 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChronSyn
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Approved from me, pending version being updated in packagejson. Currently 2.2.0-beta0 => consider bumping to version 2.3.0, and then version 3.0.0 could potentially be used for compatibility with the other project you've been investigating if any changes are needed here
* apply old iOS configurations * reset yarn * add some comments
gstcarv
approved these changes
Jan 23, 2024
brunokiafuka
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
This looks good to me. @killerchip thanks for working on this.
This was referenced Jan 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Support for SDK 50, and enables by default the JSI on Android