Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped pump pkg, use stream pipeline #404

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Dropped pump pkg, use stream pipeline #404

merged 3 commits into from
Feb 5, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 5, 2020 •
edited
Loading

pump has been integrated as stream pipeline since NodeJS v10

@gnought gnought requested a review from mcollina February 5, 2020 10:03
mcollina
mcollina reviewed Feb 5, 2020
View reviewed changes
lib/handlers/connect.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Feb 5, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit c60eeb9 into moscajs:master Feb 5, 2020
@gnought gnought deleted the feature/drop_pump branch February 5, 2020 11:39
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnought @mcollina