Introduce connecting and closed metadata #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina the PR is completed, please take you time to have a review. :) |
mcollina
reviewed
Feb 6, 2020
|
Sure. Those properties are read-only. I will use Symbol to archive that later |
|
@mcollina I will create another PR for using Symbols. This PR is completed. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connecting: show we are in CONNECT phase. Please noted thatconnackSentdoes not mean resetconnectingto false and setconnectedto true. We still need to procceed the last step, pushing (QoS>0 and !clean) / retain messages to clientsconnectedshould be flagged true whenclientReady/connectedis emittedclosed: show client closed state