Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored validationTopics into utils #447

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Refactored validationTopics into utils #447

merged 2 commits into from
Feb 23, 2020

Conversation

gnought
Copy link
Collaborator

@gnought gnought commented Feb 22, 2020

No description provided.

mcollina
mcollina requested changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving noop in the same file was on purpose. In that way it share the same closure of the rest of the functions in the file.

@gnought gnought changed the title Refactored validationTopics & noop into utils Refactored validationTopics into utils Feb 22, 2020
mcollina
mcollina approved these changes Feb 23, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gnought gnought merged commit 323d535 into moscajs:master Feb 23, 2020
@gnought gnought deleted the feature/refactor_into_utils branch February 23, 2020 16:20
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnought @mcollina