Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: LGTM badges #497

Merged
merged 2 commits into from
May 29, 2020
Merged

docs: LGTM badges #497

merged 2 commits into from
May 29, 2020

Conversation

robertsLando
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 29, 2020

Pull Request Test Coverage Report for Build 118955302

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0005%) to 99.725%

Totals Coverage Status
Change from base Build 118719047: -0.0005%
Covered Lines: 777
Relevant Lines: 777

💛 - Coveralls

@robertsLando
Copy link
Member Author

@mcollina LGTM shows this alert: https://lgtm.com/projects/g/moscajs/aedes/alerts/?mode=list

Do you think we can remove that empty buffer as var? I cannot understand why it is needed

@mcollina
Copy link
Collaborator

sure thing

@lgtm-com
Copy link

lgtm-com bot commented May 29, 2020

This pull request fixes 1 alert when merging b406ae8 into 86b6815 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit e60f85d into master May 29, 2020
@gnought gnought deleted the robertsLando-patch-3 branch February 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants