Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add $SYS/<brokerId>/new /subscribes and $SYS/<brokerId>/new /unsubscribes #540 #541

Merged
merged 8 commits into from
Sep 15, 2020
Merged

feat: add $SYS/<brokerId>/new /subscribes and $SYS/<brokerId>/new /unsubscribes #540 #541

merged 8 commits into from
Sep 15, 2020

Conversation

robertsLando
Copy link
Member

Fixes #540

@coveralls
Copy link

Pull Request Test Coverage Report for Build 254139655

  • 0 of 6 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.55%
Totals Coverage Status
Change from base Build 253993984: 0.001%
Covered Lines: 792
Relevant Lines: 793
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 14, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 255188630

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 99.55%
Totals Coverage Status
Change from base Build 253993984: 0.0008%
Covered Lines: 791
Relevant Lines: 792
💛 - Coveralls

mcollina
mcollina reviewed Sep 15, 2020
View reviewed changes
aedes.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Sep 15, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit 9f8a21a into master Sep 15, 2020
@robertsLando robertsLando deleted the sys-sub-unsub branch September 15, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Could it support client subscribe/unsubscribe notification to other client?
3 participants
@robertsLando @coveralls @mcollina