Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gebug init application name title #107

Closed
lucas-gio opened this issue Feb 28, 2021 · 2 comments · Fixed by #116
Closed

Change gebug init application name title #107

lucas-gio opened this issue Feb 28, 2021 · 2 comments · Fixed by #116
Assignees

Comments

@lucas-gio
Copy link

Problem
in gebug init, the first title say: Application Name, but here wants a docker image name instead.
I enter this in the init process:
Application Name: goRest
[...] // ...and the others fields
And i give an unexpected error:
$ gebug start
ERROR: Service 'gebug-goRest' contains uppercase characters which are not valid as part of an image name. Either use a lowercase service name or use the image field to set a custom name for the service image.

Solution
To change Application Name to Docker image name (or similar)

@moshebe
Copy link
Owner

moshebe commented Feb 28, 2021

Thanks for the detailed issue @lucas-gio!
You are right, we should handle those names as well.
But, I'm not sure if exposing them as docker image name will be the correct solution as it's only an implementation detail and should not bother as user (also, it will be prefixed and with 'gebug-' so it might be also misleading)

I think we can sanitize the input (e.g. convert the Upper case letters to lower case) for the image name but keep the application/service name as the user request. WDYT?

@lucas-gio
Copy link
Author

lucas-gio commented Feb 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants