Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split #650

Merged
merged 2 commits into from
Mar 24, 2023
Merged

feat: split #650

merged 2 commits into from
Mar 24, 2023

Conversation

Doozers
Copy link
Collaborator

@Doozers Doozers commented Mar 22, 2023

relate on #649
┆Issue is synchronized with this Trello card

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Mar 22, 2023
@Doozers Doozers force-pushed the dev/isma/split branch 2 times, most recently from 506a2d1 to 1f31218 Compare March 22, 2023 15:40
Signed-off-by: ismael FALL <ismael.fall@epitech.eu>
@Doozers
Copy link
Collaborator Author

Doozers commented Mar 23, 2023

@Doozers Doozers force-pushed the dev/isma/split branch 3 times, most recently from 3fc97c0 to 2bc4491 Compare March 23, 2023 15:32
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #650 (29a874d) into master (869435e) will increase coverage by 25.29%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #650       +/-   ##
===========================================
+ Coverage   27.95%   53.24%   +25.29%     
===========================================
  Files           6        6               
  Lines         440      231      -209     
===========================================
  Hits          123      123               
+ Misses        315      106      -209     
  Partials        2        2               
Flag Coverage Δ
unittests 53.24% <0.00%> (+25.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/dvcore/fetch.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: ismael FALL <ismael.fall@epitech.eu>
@Doozers
Copy link
Collaborator Author

Doozers commented Mar 23, 2023

hello @moul this PR actually does the split wanted, a way to fetch the db, another to display it (currently json & csv)

example

@Doozers Doozers marked this pull request as ready for review March 23, 2023 15:52
@Doozers Doozers requested a review from moul as a code owner March 23, 2023 15:52
Copy link
Owner

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 🙏

@@ -59,3 +59,25 @@ func FilterIsolatedTasks(in []Task, logger *zap.Logger) []Task {

return out
}

func (t *Task) MarshalCSV() []string {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Mar 24, 2023
@moul moul merged commit 99a3ada into moul:master Mar 24, 2023
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Mar 24, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants