Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicity specify Endpoint_url as a setting instead of crafting it from the host #269

Closed
jrconlin opened this issue Mar 24, 2021 · 0 comments · Fixed by #270 or #271
Closed

Explicity specify Endpoint_url as a setting instead of crafting it from the host #269

jrconlin opened this issue Mar 24, 2021 · 0 comments · Fixed by #270 or #271
Assignees
@jrconlin
Labels
1 Estimate - Trivial

Comments

@jrconlin
Copy link
Member

In deployment, we're seeing the host be set to 0.0.0.0, which is a valid host IP address for a server. We should explicitly set the endpoint URL so that VAPID aud can match it regardless of local deployment configurations.
@jrconlin jrconlin self-assigned this Mar 24, 2021
@jrconlin jrconlin added the 1 Estimate - Trivial label Mar 24, 2021
jrconlin added a commit that referenced this issue Mar 24, 2021
@jrconlin
bug: Add explicit endpoint_url setting
740f508 
This will add an explicit setting to specify the endpoint URL

Note that this will include `AUTOEND_ENDPOINT_URL` as a new setting, the
URL must be a fully qualified string (e.g.
`https://updates.push.services.mozilla.com/`)

Closes #269
@jrconlin jrconlin mentioned this issue Mar 24, 2021
Merged
jrconlin added a commit that referenced this issue Mar 24, 2021
@jrconlin
bug: Add explicit endpoint_url setting (#270)
5649d96 
This will add an explicit setting to specify the endpoint URL

Note that this will include `AUTOEND_ENDPOINT_URL` as a new setting, the
URL must be a fully qualified string (e.g.
`https://updates.push.services.mozilla.com/`)

Closes #269
@jrconlin jrconlin mentioned this issue Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
1 Estimate - Trivial
Projects
None yet
Milestone
No milestone
1 participant
@jrconlin