Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/136 #138

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Bug/136 #138

merged 3 commits into from
Apr 10, 2020

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Apr 10, 2020

Description

bug: double amount of allowed headers

Increasing number of security headers pushed the total over the very limited 16

Testing

Attempt to send more than 16 headers for an autopush websocket request.

e.g.

echo '{"messageType":"hello","use_webpush":true}' | /usr/bin/websocat -v \
    --header="Accept: */*" \
    --header="Cache-Control: no-cache" \
    --header="Host: push.services.mozilla.com" \
    --header="Origin: wss://push.services.mozilla.com/" \
    --header="Pragma: no-cache" \
    --header="Sec-Fetch-Dest: websocket" \
    --header="Sec-Fetch-Mode: websocket" \
    --header="Sec-Fetch-Site: cross-site" \
    --header="Sec-WebSocket-Extensions: permessage-deflate" \
    --header="Sec-WebSocket-Protocol: push-notification" \
    --header="Accept-Language: en-US,en;q=0.5" \
    --header="Accept-Encoding: gzip, deflate, br" \
    --header="Jabberwocky: T'was" \
    ws://localhost:8080

Closes #136

Increasing number of security headers pushed the total over the very
limited 16

Closes #136
@jrconlin jrconlin requested a review from a team April 10, 2020 18:17
@jrconlin jrconlin merged commit 0e272b2 into master Apr 10, 2020
@jrconlin jrconlin deleted the bug/136 branch April 10, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double amount of headers allowed
2 participants