Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fill in some autoconnect TODO docs #410

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Jul 25, 2023

SYNC-3742

(against #409)

@pjenvey pjenvey requested a review from jrconlin July 25, 2023 18:36
@pjenvey pjenvey force-pushed the docs/autoconnect-TODO-docs-SYNC-3742 branch 3 times, most recently from 766e4ca to 9019829 Compare July 25, 2023 19:59
jrconlin
jrconlin previously approved these changes Jul 25, 2023
@pjenvey pjenvey dismissed jrconlin’s stale review July 26, 2023 18:02

The merge-base changed after approval.

@pjenvey pjenvey force-pushed the docs/autoconnect-TODO-docs-SYNC-3742 branch from 9019829 to bcce6b7 Compare July 26, 2023 18:04
@pjenvey
Copy link
Member Author

pjenvey commented Jul 26, 2023

Just rebased against master (since #409 squashed over to master)

@pjenvey pjenvey merged commit 74ffdb0 into master Jul 26, 2023
1 check passed
@pjenvey pjenvey deleted the docs/autoconnect-TODO-docs-SYNC-3742 branch July 26, 2023 18:26
@jrconlin jrconlin mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants