Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split router endpoints into their own app #491

Merged
merged 3 commits into from
Oct 30, 2023
Merged

fix: split router endpoints into their own app #491

merged 3 commits into from
Oct 30, 2023

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Oct 30, 2023

which binds solely to the router port

SYNC-3979

@pjenvey
fix: split router endpoints into their own app
38bc541 
which binds solely to the router port

SYNC-3979
@pjenvey pjenvey requested a review from jrconlin October 30, 2023 21:16
jrconlin
jrconlin previously approved these changes Oct 30, 2023
View reviewed changes
autoconnect/src/main.rs Outdated Show resolved Hide resolved
@pjenvey
Copy link
Member Author

pjenvey commented Oct 30, 2023

I also audited any actix-ws use of app_info. Obviously it only references anything from HttpRequest (the likely place where app_info would be used) during the WS handshake.

The handshake's handled by actix-http::ws, which only uses RequestHead to, as one would imagine, look at headers.

@jrconlin jrconlin merged commit bbde582 into master Oct 30, 2023
1 check passed
@jrconlin jrconlin deleted the fix/router-endpoints-SYNC-3979 branch October 30, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin