feat: return broadcast errors for invalid broadcast id's #63
Conversation
src/server/mod.rs
Outdated
| ); | ||
| } | ||
| if let Some(delta) = bc.subscribe_to_broadcasts(broadcast_subs, broadcasts) { | ||
| for (k, v) in Broadcast::into_hashmap(delta).into_iter() { |
There was a problem hiding this comment.
you can do response.extend(Broadcast::into_hashmap(delta)) here
There was a problem hiding this comment.
I tried to do something like that, but extend wants references, and doing that provides ownership, so the types didn't match.
There was a problem hiding this comment.
Odd, doing it that way works, I guess there's an Into that was satisfied.
src/util/megaphone.rs
Outdated
| @@ -86,12 +98,18 @@ impl From<Broadcast> for (String, String) { | |||
| } | |||
| } | |||
|
|
|||
| impl From<Broadcast> for (String, BroadcastValue) { | |||
There was a problem hiding this comment.
the From for (String, String) above this is now no longer used, let's kill it
bbangert
force-pushed
the
feat/issue-59
branch
from
d4e936a
to
ee7cb91
Compare
|
I was trying to avoid updating the API too much, and trying to keep concerns separate. ie, having megaphone handle it directly seemed to expose too much knowledge about the final output (JSON serialization). So the server API has knowledge of the final output seemed a better trade-off. |
Closes #59