Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Rust 1.58 and switch to GCP Rust crate #1201

Merged
merged 9 commits into from
Jan 24, 2022
Merged

Conversation

ethowitz
Copy link
Contributor

@ethowitz ethowitz commented Jan 19, 2022

Description

Update to Rust 1.58 and start using the google-cloud-rust-raw crate instead of vendoring the GCP code.

Testing

N/A

Issue(s)

N/A

@ethowitz ethowitz requested a review from a team January 19, 2022 16:40
@jrconlin
Copy link
Member

oof. Looks like a minor fmt fail.
Also, did you want to bump things up to edition="2021" while you have the chance? From what I've seen, there's no impact to existing code from fmt or clippy

@jrconlin
Copy link
Member

Sigh, and looks like after a cargo update, there's a new version of protobuf.

@ethowitz
Copy link
Contributor Author

I suppose we'll need to rebuild the GCP Rust bindings then?

@jrconlin
Copy link
Member

Not necessarily, or at least, not a full rebuild should be required. There are steps in the vendored directory you can do.
I can also try doing a PR that is just that part.

@ethowitz
Copy link
Contributor Author

I'll give it a shot!

@ethowitz ethowitz changed the title chore: update to Rust 1.58 chore: update to Rust 1.58 and switch to GCP Rust crate Jan 19, 2022
Comment on lines 100 to 101
#[allow(clippy::non_send_fields_in_send_ty)]
unsafe impl Send for MysqlDb {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's kill this, the warning was reverted in 1.58.1

Suggested change
#[allow(clippy::non_send_fields_in_send_ty)]
unsafe impl Send for MysqlDb {}
unsafe impl Send for MysqlDb {}

@@ -1,4 +1,4 @@
FROM rust:1.57-buster as builder
FROM rust:1.58-buster as builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well since this hasn't merged yet (and its docker is up now) :)

Suggested change
FROM rust:1.58-buster as builder
FROM rust:1.58.1-buster as builder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if you specify 1.58, it pulls in the latest version subversion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a docker pull rust:1.58-buster and an internal shell
rustup show shows 1.58.1

@ethowitz ethowitz merged commit a7c5f80 into master Jan 24, 2022
@ethowitz ethowitz deleted the rust-updates branch January 24, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants