Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Catalan translation. #357

Merged
merged 4 commits into from
Jan 29, 2014
Merged

Add Catalan translation. #357

merged 4 commits into from
Jan 29, 2014

Conversation

lua86
Copy link

@lua86 lua86 commented Jan 28, 2014

I do not know anything about coding -yet-, but I hope I added all needed for the Catalan translation being usable.

@cpeterso
Copy link
Contributor

@lua86: Thanks for the Catalan translation. Can you please fix these errors in your values.xml file? The apostrophe is a special character in Android's translation files, so you need to "escape" it using a backslash like Servei de reconeiximent d\'activitat de Mozilla Stumbler.

res/all/debug/values-ca/values.xml:13: error: Apostrophe not preceded by \ (in Servei de reconeiximent d'activitat de Mozilla Stumbler)
res/all/debug/values-ca/values.xml:30: error: Apostrophe not preceded by \ (in Temps de l'ùltima càrrega: %1$s)
res/all/debug/values-ca/values.xml:34: error: Apostrophe not preceded by \ (in Mode d'estalvi d'energia)
res/all/debug/values-ca/values.xml:35: error: Apostrophe not preceded by \ (in Quan activat, només s'escanejarà quan es mou)
res/all/debug/values-ca/values.xml:47: error: Apostrophe not preceded by \ (in Punts d'accés WiFi visibles: %1$d)
res/all/debug/values-ca/values.xml:48: error: Apostrophe not preceded by \ (in Punts d'accés WiFi escanejats: %1$d)

@cpeterso
Copy link
Contributor

Also, when you've fixed and committed your value.xml file, can you please use git rebase to squash your branch's commits into a single commit? Here are instructions for squashing git commits: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@lua86
Copy link
Author

lua86 commented Jan 28, 2014

So, first fixing apos and committing, then squashing the old commits with rebase, then pushing. And then?

@lua86
Copy link
Author

lua86 commented Jan 28, 2014

Well I tried. I hope I didn't make much of a mess.

@cpeterso
Copy link
Contributor

hi @lua86, I've fixed the apostrophe problem, but can you please squash your intermediate commits into one commit? I think you need to:

  1. git rebase --interactive HEAD~4
  2. Change the last three picks to fixup for "Fixing Catalan Translation", "Merging Upstream" and "Remove Catalan translation strings backup". Leave the first pick for "Add Catalan translation." git will then squash all four commits into one called "Add Catalan translation."
  3. Then git push --force your branch to update your GitHub repo and this pull request should automatically be updated.

@lua86
Copy link
Author

lua86 commented Jan 29, 2014

GNU nano 2.2.6 Fitxer: /home/lua/MozStumbler/.git/rebase-merge/git-rebase-todo

pick 0b967e2 Optionally use the new getAllCellInfo API (#72)
pick 31e8aa1 Add Catalan translation.
pick 56ff399 Added Italian translation
pick 6048a71 Added Italian translation
#I cannot find my intermediate commits. Seems I got messed up. Or maybe did something weird to my local repo.

@cpeterso
Copy link
Contributor

@lua86: I don't think you messed up your repo. I still see all your commits. I will just merge them as-is. Thanks for your help and patience!

cpeterso added a commit that referenced this pull request Jan 29, 2014
Add Catalan translation.
@cpeterso cpeterso merged commit 50744a7 into mozilla:master Jan 29, 2014
@lua86
Copy link
Author

lua86 commented Jan 29, 2014

I meant I messed up my local copy. Also, thank you for your patience. Now I should learn more about git, github, and Android 'special' things with xml...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants