Fix Error Catching and Screenshot Functionality #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarinali
requested review from
sv-hyacoub,
Tracy-Walker,
soncuteanca,
ben-c-at-moz and
vsangereanMOZ
ben-c-at-moz
previously approved these changes
Aug 19, 2024
ben-c-at-moz
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes code written to catch exceptions and failures in tests to screenshot the entire screen and what is captured by the driver. Also ensures that the INTERNAL ERROR does not show up anymore (before an exception was being raised due to failures, now it will simply log and error and move on.)
Note that on Linux CI: wayland machines prevent screenshotting (its a feature...) python-pillow/Pillow#6312 so screenshotting the entire screen is not possible on Linux CI without other libraries. Perhaps this is a come back to feature.
Additional work was done in GHA to ensure that headed tests run if the setup runs correctly and does not depend on the previous unheaded tests to pass anymore.