Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning on failure of llvm-cov #757

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Log warning on failure of llvm-cov #757

merged 1 commit into from
Jan 24, 2022

Conversation

dwhjames
Copy link
Contributor

example:

06:21:49 [WARN] Suppressing error returned by Cov Tool for binary "./target/debug/…"
Failure while running "…/bin/llvm-cov" "export" "./target/debug/…" "--instr-profile" "/var/folders/rw/41zljw1j29j9fhbcckn0crdm0000gp/T/.tmplkPlUT/3/grcov.profdata" "--format" "lcov"
error: ./target/debug/…: Failed to load coverage: Truncated coverage data
error: Could not load coverage information

Stacked on PR #756

@dwhjames
Copy link
Contributor Author

dwhjames commented Jan 23, 2022 •
edited
Loading

Motivated by the difficulty of finding a cause for missing coverage:

@marco-c
Copy link
Collaborator

marco-c commented Jan 24, 2022

Could you rebase on top of master?

marco-c
marco-c reviewed Jan 24, 2022
View reviewed changes
src/llvm_tools.rs Outdated Show resolved Hide resolved
@dwhjames
Log warning on failure of llvm-cov
eae71eb 
example:
```
06:21:49 [WARN] Suppressing error returned by llvm-cov tool for binary "./target/debug/…"
Failure while running "…/bin/llvm-cov" "export" "./target/debug/…" "--instr-profile" "/var/folders/rw/41zljw1j29j9fhbcckn0crdm0000gp/T/.tmplkPlUT/3/grcov.profdata" "--format" "lcov"
error: ./target/debug/…: Failed to load coverage: Truncated coverage data
error: Could not load coverage information
```
@dwhjames dwhjames marked this pull request as ready for review January 24, 2022 17:27
@dwhjames dwhjames requested a review from marco-c January 24, 2022 17:27
marco-c
marco-c approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit 2a150f2 into mozilla:master Jan 24, 2022
@dwhjames dwhjames deleted the warn-cov-failure branch January 24, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwhjames @marco-c