Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1041. Handles {0} quantifier with max of zero correctly. #1098

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

MaxisTekfield
Copy link
Contributor

I've fixed the issue #1041 .

Closes #1041

@MaxisTekfield MaxisTekfield force-pushed the issue-1041 branch 2 times, most recently from db778e9 to 5acc124 Compare November 27, 2021 12:22
@p-bakker
Copy link
Collaborator

Thnx for your contribution!

I see that you included a unit test: isn't this JavaScript behavior covered by a test in the Test262 suite, that was failing and now started passing?

@MaxisTekfield

This comment has been minimized.

@MaxisTekfield
Copy link
Contributor Author

Thnx for your contribution!

I see that you included a unit test: isn't this JavaScript behavior covered by a test in the Test262 suite, that was failing and now started passing?

I cannot find any corrsponding test in test262. Only test262/implementation-contributed/v8/mjsunit/third_party/regexp-pcre/regexp-pcre.js has some cases as follows:

// ...
res[903] = /a{0}bc/;
// ...
assertToStringEquals("bc", res[903].exec("bc"), 2782);
// ...

It seems that we don't run any cases under test262/implementation-contributed at all.

@p-bakker
Copy link
Collaborator

K, maybe such test exists in a more recent version of the Test262 suite, but unfortunately we cannot run the latest version, as Rhino misses a bunch of features newer versions of the test suite depends on.

So I guess a dedicated test is in order 🙂

And we're indeed not running the 'implementation contributed' tests: those are contributed to the test262 suite repo for eventual inclusion in the main test suite.

@p-bakker p-bakker modified the milestone: Release 1.7.15 Nov 28, 2021
@p-bakker p-bakker modified the milestone: Release 1.7.15 Jan 10, 2022
@gbrail
Copy link
Collaborator

gbrail commented Jan 27, 2022

This works great. Thanks!

@gbrail gbrail merged commit 0ada26b into mozilla:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RegExp does not handle quantifier with max of zero correctly
3 participants