Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit the length of the string to be used for indentation #1428

Merged
merged 2 commits into from
Jan 15, 2024
Merged

limit the length of the string to be used for indentation #1428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e7ef3
limit the length of the string to be used for indentation
rbri Dec 9, 2023
4679df0
ups
rbri Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/org/mozilla/javascript/ast/AstNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ public abstract class AstNode extends Node implements Comparable<AstNode> {
protected AstNode inlineComment;
private static Map<Integer, String> operatorNames = new HashMap<>();

private static final int MAX_INDENT = 42;
private static final String[] INDENTATIONS = new String[MAX_INDENT + 1];

static {
operatorNames.put(Token.IN, "in");
operatorNames.put(Token.TYPEOF, "typeof");
Expand Down Expand Up @@ -120,6 +123,13 @@ public abstract class AstNode extends Node implements Comparable<AstNode> {
operatorNames.put(Token.ASSIGN_BITXOR, "^=");
operatorNames.put(Token.ASSIGN_EXP, "**=");
operatorNames.put(Token.VOID, "void");

StringBuilder sb = new StringBuilder();
INDENTATIONS[0] = sb.toString();
for (int i = 1; i <= MAX_INDENT; i++) {
sb.append(" ");
INDENTATIONS[i] = sb.toString();
}
}

public static class PositionComparator implements Comparator<AstNode>, Serializable {
Expand Down Expand Up @@ -299,11 +309,8 @@ public String toSource() {
* @param indent the number of indentation steps
*/
public String makeIndent(int indent) {
StringBuilder sb = new StringBuilder();
for (int i = 0; i < indent; i++) {
sb.append(" ");
}
return sb.toString();
indent = Math.min(MAX_INDENT, Math.max(0, indent));
return INDENTATIONS[indent];
}

/** Returns a short, descriptive name for the node, such as "ArrayComprehension". */
Expand Down