some fixes/enhancements for the typed array support #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbri
changed the title
… from the architecture they run on. So far Rhino always uses big endian. With this patch we are able to simulate little endian also by setting a context feature.
|
Hi Greg, |
…endian and not architecture dependent
|
Looks good to me. Would you mind if I squashed these into one commit (or would you mind doing it?) |
|
Great, please squash if you like (i'm still a git(hub) beginner and not sure how to do it) |
|
Well there's the hard way and the easy way and the easy way is to press the button in GitHub when I merge the PR ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.