Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #616 #617

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Fix for #616 #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8462669
Fix for #616
stijnkliemesch Nov 8, 2019
6bd5cf3
Removed exclusion for test262 tests that succeed since 8462669d278b2c…
stijnkliemesch Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/org/mozilla/javascript/ScriptableObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2804,20 +2804,18 @@ private boolean putImpl(Object key, int index, Scriptable start,
{
// This method is very hot (basically called on each assignment)
// so we inline the extensible/sealed checks below.
if (!isExtensible) {
Context cx = Context.getContext();
if (cx.isStrictMode()) {
throw ScriptRuntime.typeError0("msg.not.extensible");
}
}
Slot slot;
if (this != start) {
slot = slotMap.query(key, index);
if(!isExtensible && Context.getContext().isStrictMode() && (slot == null || !(slot instanceof GetterSlot)))
throw ScriptRuntime.typeError0("msg.not.extensible");
if (slot == null) {
return false;
}
} else if (!isExtensible) {
slot = slotMap.query(key, index);
if(Context.getContext().isStrictMode() && (slot == null || !(slot instanceof GetterSlot)))
throw ScriptRuntime.typeError0("msg.not.extensible");
if (slot == null) {
return true;
}
Expand Down
3 changes: 0 additions & 3 deletions testsrc/test262.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,9 +481,6 @@ built-ins/Object
! entries/tamper-with-object-keys.js
! freeze/15.2.3.9-2-a-12.js
! freeze/15.2.3.9-2-a-8.js
! freeze/15.2.3.9-2-c-2.js
! freeze/15.2.3.9-2-c-3.js
! freeze/15.2.3.9-2-c-4.js
! freeze/15.2.3.9-2-d-3.js
! freeze/frozen-object-contains-symbol-properties-non-strict.js
! getOwnPropertyDescriptor/15.2.3.3-3-14.js
Expand Down