Compress toolchains in parallel fashion via gzp crate
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this requires rustc 1.49. see rust-lang/rust#55002 |
|
I'll look into this in a couple days, I need to sort out what restrictions we have on our MSRV first :) |
|
Ok, this is blocked on this ticket, which should be resolved after our next release. |
drahnr
approved these changes
May 5, 2022
|
Why not switch to zstd? |
|
I think one step at a time. Even if we move to zstd, this PR is still a viable addition. Could you update the manifest and lockfile by merging master? |
Xanewok
force-pushed
the
igor-par-compress
branch
from
e91b662
to
6240a2b
Compare
Done! Sorry, I somewhat filled in the blanks in my head and thought you meant rebase, so that's what I did. Hope that's okay. |
drahnr
approved these changes
May 20, 2022
emabrey
pushed a commit
to emabrey/sccache
that referenced
this pull request
Aug 10, 2022
* Compress toolchains in parallel fashion via `gzp` crate * Use previous compression level of 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed toolchain packaging/compression by a considerable amount on multithreaded systems.
Cherry-pick of paritytech/cachepot#127, see discussion there