-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Intermediate security policy for AWS ALB #81
Conversation
@gene1wood, this looks fine to me, but I thought I'd run it by you to see if you had any caveats. |
I have very little love for old versions of Windows or Internet Explorer, but I do want to note that's why the DHE-RSA suites are present in Intermediate. If you're okay dropping them, then at least you're doing it on purpose and not on accident. ❤️ |
I fully agree with keeping compatibility with Internet Explorer 11 on Windows 7 as specified for the Intermediate configuration. Looking at mozilla/server-side-tls#178 (comment), another requirement seems to be keeping compatibility even if the server uses a certificate with an RSA key. For AWS ALB, I think this is taken care of by ECDHE-RSA-AES128-SHA256 which is not present in the Intermediate configuration but is present in both the old and new security policy. The corresponding IANA name, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, is listed on Qualys SSL Labs’s user agent capabilities page. |
Yep, that was my thought as well. Basically they prefer |
Sorry! I missed the fact that the table is not aligned. I read the first column (which is 100% FS and AEAD) and didn't realize the second and third columns were completely different. This change is a definite improvement because nothing at the Intermediate level is being lost by this change (comparing the before "middle" and the after "right" columns). Not that they're likely to make changes after the fact, but it would make me a bit happier if @awslabs dropped ECDHE-ECDSA-AES128-SHA256 and ECDHE-ECDSA-AES256-SHA384 from that preset. |
Sorry, I definitely see how the table can be confusing. To be clear, the old and new security policies are the same except for the new one no longer including AES128-GCM-SHA256, AES128-SHA256, AES256-GCM-SHA384, and AES256-SHA256 (the last four in the middle column). As to the Intermediate configuration, the security policy shares the first four cipher suites but does not include any ChaCha20-Poly1305 and DHE cipher suites (the last four in the first column). Instead, it includes ECDHE-ECDSA-AES128-SHA256, ECDHE-RSA-AES128-SHA256, ECDHE-ECDSA-AES256-SHA384, and ECDHE-RSA-AES256-SHA384. Looking at the AWS documentation, there’s no security policy stricter than this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking approved so that it is clear my prior concern has been fully resolved, even though I have no real power. Thank you @sonicdoe!
I haven't heard from @gene1wood, but I think my concerns have been allayed here. :) |
Updates the Intermediate configuration for Amazon Web Services’s Application Load Balancer to
ELBSecurityPolicy-FS-1-2-Res-2019-08
which was added on October 8, 2019.This policy is the same as the previous
ELBSecurityPolicy-TLS-1-2-2017-01
but removes support for AES128-GCM-SHA256, AES128-SHA256, AES256-GCM-SHA384, and AES256-SHA256.Here’s a table comparing the TLS 1.2 cipher suites of the Intermediate configuration, the previous
ELBSecurityPolicy-TLS-1-2-2017-01
security policy, and the newELBSecurityPolicy-FS-1-2-Res-2019-08
security policy: