Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump redis to 4.5.5 #7727

Closed
wants to merge 1 commit into from
Closed

Conversation

vrigal
Copy link
Collaborator

@vrigal vrigal commented Jun 21, 2023

It was necessary to bump mozci to release the redis major constraint.

* Allows to bum redis==4.5.5
* Drop boto3 dependency
@vrigal
Copy link
Collaborator Author

vrigal commented Jun 21, 2023

Some dependencies are missing building dependencies with the new mozci requirement (> 2.0) using pip-compile:

  • zstandard (defined in mozci pyproject.toml though)
  • boto3 optional dependency

The application cannot start yet because of those missing deps.

@jmaher
Copy link
Collaborator

jmaher commented Jul 4, 2023

2023-06-21 10:02:55.287 | WARNING | mozci.configuration:init:149 - Configuration path /home/.config/mozci/config.toml is not a file.
______________ ERROR collecting tests/push_health/test_compare.py ______________
ImportError while importing test module '/app/tests/push_health/test_compare.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.9/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/push_health/test_compare.py:6: in
from treeherder.push_health.compare import get_commit_history
treeherder/push_health/compare.py:2: in
from mozci.push import Push as MozciPush
/usr/local/lib/python3.9/site-packages/mozci/init.py:2: in
from mozci.configuration import config # noqa
/usr/local/lib/python3.9/site-packages/mozci/configuration.py:226: in
config = Configuration()
/usr/local/lib/python3.9/site-packages/mozci/configuration.py:154: in init
self.cache = CustomCacheManager(self._config["cache"])
/usr/local/lib/python3.9/site-packages/mozci/configuration.py:96: in init
self.register_serializer("compressedpickle", CompressedPickleSerializer())
/usr/local/lib/python3.9/site-packages/mozci/util/cache_stores.py:238: in init
import zstandard
E ModuleNotFoundError: No module named 'zstandard'

@vrigal
Copy link
Collaborator Author

vrigal commented Jul 5, 2023

Closed in favor of #7730

@vrigal vrigal closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants