Don't pass non-UTF-8 bytes as string from Ruby to Rust #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be UB on the Rust side. Add some tests verifying that this is caught in both Ruby and Python.
badboy
approved these changes
Jun 15, 2023
heinrich5991
added a commit
to heinrich5991/uniffi-rs
that referenced
this pull request
Jun 15, 2023
Also fixes that bytes had to be valid UTF-8 due to mozilla#1595.
heinrich5991
added a commit
to heinrich5991/uniffi-rs
that referenced
this pull request
Jun 15, 2023
Also fixes that bytes had to be valid UTF-8 due to mozilla#1595.
badboy
pushed a commit
that referenced
this pull request
Jun 19, 2023
Also fixes that bytes had to be valid UTF-8 due to #1595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be UB on the Rust side. Add some tests verifying that this is caught in both Ruby and Python.