This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Wait to load URI from intent until after session restore. #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to make this part of the v10.2 release. Regressed by #3364 |
bluemarvin
force-pushed
the
intent-launch
branch
2 times, most recently
from
d398ae5
to
2ebd367
Compare
keianhzo
suggested changes
Jun 2, 2020
There was a problem hiding this comment.
LGTM.
Maybe we could also replace:
By:
if (GeckoRuntime.ACTION_CRASHED.equals(intent.getAction())) {
Log.e(LOGTAG, "Restarted after a crash");
} else {
loadFromIntent(intent);
}
As some adb commands like:
adb shell am start -n org.mozilla.vrbrowser.dev/org.mozilla.vrbrowser.VRBrowserActivity "https://example.com"
are not working right now.
Fixes #3431 This patch changes the behavior of launching or opening a URI from an intent. Previously the URI would be opened in the focuses window. With this patch it matches Fenix and desktop and creates a new tab in the focused window.
|
@keianhzo Updated. |
keianhzo
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3431
This patch changes the behavior of launching or opening a URI
from an intent. Previously the URI would be opened in the focuses window.
With this patch it matches Fenix and desktop and creates a new tab in the
focused window.