Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pushbullet]: Modernize service plugin #676

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Pushbullet]: Modernize service plugin #676

merged 1 commit into from
Jul 20, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented May 23, 2023

About

Modernize Pushbullet service plugin.

Details

  • Use Python 3
  • Remove external dependencies
  • Use named-parameter configuration style, with backwards-compatibility to the previous configuration style

References

Resources

- Use Python 3
- Remove external dependencies
- Use named-parameter configuration style
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.93 🎉

Comparison is base (288392f) 47.94% compared to head (93d65bf) 48.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   47.94%   48.88%   +0.93%     
==========================================
  Files          81       81              
  Lines        3917     3938      +21     
==========================================
+ Hits         1878     1925      +47     
+ Misses       2039     2013      -26     
Flag Coverage Δ
unittests 48.88% <100.00%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mqttwarn/services/pushbullet.py 100.00% <100.00%> (+100.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl amotl requested review from jpmens and sumnerboy12 May 23, 2023 00:53
@amotl amotl added service plugin All about service plugins quality All things QA, software tests, and maintenance labels May 23, 2023
@amotl amotl marked this pull request as ready for review May 23, 2023 00:54
@amotl amotl mentioned this pull request May 23, 2023
@DNicholai
Copy link

DNicholai commented May 24, 2023

Dear Andreas, Dear all,

I've just tested this and I can confirm it's working, thank you so much ^^

I am running the following command :

sudo docker run --rm -it --name=mqttwarn_test --volume=$PWD:/etc/mqttwarn ghcr.io/mqtt-tools/mqttwarn-standard:pr-676 mqttwarn

/!\ -- Quick note for any users following at home :
The command which worked for me is slightly different than the command as suggested above as I am not using the appended version specifier. I suspect it defaults to the correct version. Notably, I am not appending the portion in bold

sudo docker run --rm -it --name=mqttwarn_test --volume=$PWD:/etc/mqttwarn ghcr.io/mqtt-tools/mqttwarn-standard:pr-676 mqttwarn --version mqttwarn 0.34.1.post5+gf4a6a9e.d20230523

I confirm as well that once configured, this setup gives successful pushes to my pushbullet client.

BR,
David

@amotl
Copy link
Member Author

amotl commented May 24, 2023

Hi David,

thanks a stack for your positive response. So, when there are no other objections, let's merge this improvement.

With kind regards,
Andreas.

@amotl amotl merged commit eeb37e3 into main Jul 20, 2023
@amotl amotl deleted the amo/pushbullet branch July 20, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality All things QA, software tests, and maintenance service plugin All about service plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants