Time Changing Vaccine Efficacy Changes #22
Conversation
src/parameters.js
Outdated
| @@ -90,6 +92,25 @@ export const createParameters = ( | |||
| this.infectionEfficacy[4] = vaccinatedInfectedEff; | |||
| return this; | |||
| }, | |||
| withVaccineEfficacy: function(diseaseEfficacy, infectionEfficacy) { | |||
There was a problem hiding this comment.
this shouldn;t been duplicated.my bad
There was a problem hiding this comment.
The Reff function and vaccine parameterisation appears to work from the unittests.
...it probably isn't super fast...
Are you up for polishing up the documentation and releasing?
I haven't done an e2e test for varying efficacy. I can leave that to you if you want?
| # these parameters are found in pars_0.json that is imported in index.js | ||
| dur_ICase <- out$parameters$dur_ICase | ||
| dur_IMild <- out$parameters$dur_IMild | ||
| prob_hosp <- out$odin_parameters$prob_hosp | ||
| rel_infectiousness <- out$odin_parameters$rel_infectiousness_vaccinated |
There was a problem hiding this comment.
Yup we can. sorry for the confusion
|
Oh, there's a weird babel issue. Will look into it |
Happy to write the documentation etc for this as will be chatting to Andy to help explain how to plumb it all together. i can then write a test to use one of the current model fits to make sure it is working right. |
* remove babel * e2e parameterisation of efficacy
|
Ok, sorry for the late commit... Babel is breaking and I don't know why or how to fix it. So I've removed it. It's not essential that we spend time on maintaining Babel. Babel just makes sure that our javascript bundle works on all recent browsers. But I'm sure clients can figure out a Babel configuration that works for them and run the bundle through it themselves. I've updated the e2e/test.js to use the new vaccine efficacy methods. |
Start of a PR to adapt to new nimue version (0.1.18), which has time changing vaccine efficacies.
This is a draft as it is half way there for implementing:
Most of these changes have been written up in
Rso far but I am very out of my depth translating this tojs. Priority is 1 and 2. 3 being longer term is okay