Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial fix needsUpdate #15674

Merged
merged 1 commit into from
Mar 5, 2019
Merged

NodeMaterial fix needsUpdate #15674

merged 1 commit into from
Mar 5, 2019

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 31, 2019

it is a hack was the best so far

@sunag
Copy link
Collaborator Author

sunag commented Jan 31, 2019

#15666

@sunag
Copy link
Collaborator Author

sunag commented Jan 31, 2019

It seems like I have a different solution to that old problem.
#14442

/ping @Mugen87

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 31, 2019

Um, we still need the fix in the renderer for the other materials, right?

@sunag
Copy link
Collaborator Author

sunag commented Jan 31, 2019

I think so. After the first compile, define needsUpdate = true is indifferent to customize a diferente shader using onBeforeCompile. programCache.getProgramCode( material, parameters ) returns always the same value without this fix in this case.

This only works because of it:

array.push( material.onBeforeCompile.toString() );

@mrdoob mrdoob added this to the r103 milestone Mar 5, 2019
@mrdoob mrdoob merged commit 1ec8793 into mrdoob:dev Mar 5, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 5, 2019

Thanks!

@sunag sunag deleted the dev-fixes branch June 3, 2019 22:57
@sunag sunag mentioned this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants