Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Use single parameter object for program acquisition. #18279

Merged
merged 2 commits into from
Jan 2, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 31, 2019

Replacement of #15045. Thanks to @gero3 for his previous work!

The idea of this PR is to acquire the shader programs from a single parameters object. This makes the code in WebGLRenderer.initMaterial(), WebGLProgram and WebGLPrograms more clear. It's also not necessary anymore to call getProgramCacheKey() twice since onBeforeCompile() is now always called before the program cache key is computed.

@mrdoob mrdoob added this to the r113 milestone Jan 2, 2020
@mrdoob mrdoob merged commit 2c52b41 into mrdoob:dev Jan 2, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants