NodeMaterial: Do not access materialProperties. #20126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Aug 19, 2020
|
|
||
| if ( this.version !== materialProperties.__version ) { |
There was a problem hiding this comment.
Since Material.onBeforeCompile() was previously called way more often than now, I suspect this check should prevent unnecessary material builds. However, just checking for materialProperties.__version is not correct anyway since program updates might be necessary because of other reasons (e.g. WebGLRenderer.outputEncoding changes).
Hence, it's more correct if the material system let WebGLRenderer decide when to update shaders.
sunag
approved these changes
Aug 19, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeMaterial.onBeforeCompile()should not accessmaterialPropertieswhich is for internal use only. AFAICS, after the introduction ofNodeMaterial.getHash()and the refactoring of whenonBeforeCompile()is executed inWebGLRenderer, this check is not necessary anymore.Sidenote: In order to solve #15047, the access to renderer internals like
materialPropertiesshould stop anyway.