Update tween library #25607
Merged
Update tween library #25607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Mar 3, 2023
Methuselah96
force-pushed
the
update-tween
branch
2 times, most recently
from
51b8ec0
to
6960b59
Compare
Mugen87
approved these changes
Mar 3, 2023
Methuselah96
force-pushed
the
update-tween
branch
from
6960b59
to
7237e29
Compare
|
Sorry, didn't mean to push after you approved, I was just getting rid of some extra newlines that accidentally got added at the ends of the files I was editing. |
In the meanwhile, I personally prefer to use the official builds of third-party projects and don't modify them anymore. Makes the maintenance easier. If devs want minification, it's best to use a build tool and manage |
37 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
This PR updates tween.js from 17.3.5 to the latest version (18.6.4).
The main motivation behind updating tween.js is so that the
@types/threecan re-use the types provided by tween.js, which were added in tween.js 18.6.Other notes:
TWEENthe default export instead of exporting it by name (which is how it's currently exported by three.js as of JSM: Added ES6 version of tween.js. #16947).