SkinnedMesh: Add bounding volumes. #25612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait since when there is bounding sphere/box on object3d-s? I thought it was always only on geometries. |
|
@mrdoob I'm aware of a more performant approach that you have outlined in google/model-viewer#3189 (comment). However, I could not get it to work yet since I'm struggling with some coordinate spaces issues. I'll go ahead and merge this PR so we have something in |
Merged
Thanks for looking into it! 🙏 |
This was referenced Apr 25, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #14499.
Description
This PR adds bounding volume computations for
SkinnedMeshwhich should fix a long-standing culling issue.Note: If a skinned mesh is animated,
computeBoundingSphere()has to be called per frame for correct view frustum culling.