Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Added damping to LDrawLoader example #25656

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

WestLangley
Copy link
Collaborator

This example already had an animation loop, so I added damping.

@WestLangley WestLangley added this to the r151 milestone Mar 11, 2023
@WestLangley
Copy link
Collaborator Author

Unrelated to this PR, this example appears to have a bug when toggling "Merge Model".

master: https://threejs.org/examples/webgl_loader_ldraw.html

/ping @gkjohnson

@gkjohnson
Copy link
Collaborator

Unrelated to this PR, this example appears to have a bug when toggling "Merge Model".

Looks like this broke between r146 and r147

@gkjohnson
Copy link
Collaborator

@Mugen87 Mugen87 merged commit 91b4dc2 into mrdoob:dev Mar 12, 2023
@WestLangley WestLangley deleted the dev-ldraw_example branch March 12, 2023 17:21
@WestLangley
Copy link
Collaborator Author

The visibility calculation fails here when toggling "Merge Model". Some inputs can be undefined.

// Hide objects with building step > gui setting
c.visible = c.userData.buildingStep <= guiData.buildingStep;

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants