Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to safe-utf 7 to avoid vulnerability notifications #911

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alisonaquinas
Copy link

I've been working with this library recently for a personal project, and I'm hugely grateful for the work that's gone into it! The problem I ran into is that semver, a dependency of utf7 has a known vulnerability:

$ npm audit
# npm audit report

semver  <5.7.2
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install utf7@1.0.1, which is a breaking change
node_modules/semver
  utf7  >=1.0.2
  Depends on vulnerable versions of semver
  node_modules/utf7

2 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Unfortunately, Konstantin, who created the utf7 library, never published the code on a public repository where a Pull request could be submitted. I've reached out to him directly, but in the meantime, I introduced https://github.com/alisonaquinas/node-safe-utf7 to resolve the issue.

@alisonaquinas alisonaquinas marked this pull request as draft November 4, 2023 21:55
@alisonaquinas
Copy link
Author

got back to me and pointed me to https://github.com/kkaefer/utf7/, I've posted kkaefer/utf7#15

@alisonaquinas alisonaquinas marked this pull request as ready for review November 10, 2023 00:24
@alisonaquinas
Copy link
Author

I've not heard back from Konstantin despite my best efforts. He's not been merging PRs at all, given the state of other PRs and issues. My latest version removes the need for semver completely.

@ducphu0ng
Copy link

Hi! are there some news about this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants