Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to NuGet packages #306

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Add missing dependencies to NuGet packages #306

merged 1 commit into from
Nov 7, 2018

Conversation

lucaspimentel
Copy link
Contributor

@lucaspimentel lucaspimentel commented Nov 1, 2018

Add missing .NETStandard2.0 dependencies to NuGet package. The System.CodeDom reference, in particular, is causing this issue and probably #283, too.
(edit: grammar)

@yfakariya
Copy link
Member

Thank you!

Would you make more PR again for master branch?

@yfakariya yfakariya merged commit 64ac736 into msgpack:1.0.x Nov 7, 2018
@yichunzhao
Copy link

I am new on c# could you please write out which package i need to install, and how

@yichunzhao
Copy link

why I didn't see .NETStandard2.0 from NuGet, could you please explain clearly?

@yfakariya
Copy link
Member

@yichunzhao

Could you give actual error message text which you saw?
I believe that all dependent package should be listed in nuspec file, but something went wrong in your environment unfortunatelly, so I may help you if you give more information.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants