Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to use virtual workspace #850

Closed
wants to merge 2 commits into from
Closed

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented Mar 2, 2021

  • fixes num tests starting from 1.51.0 aka current beta
    • cargo stabilized feature package-features making --feature and --no-default-features
      work as expected for virtual workspaces, though apparently not workspaces with
      a root package

* fixes num tests from 1.51.0 aka current beta
  * cargo stabilized package-features making `--feature` and `--no-default-features`
    work as expected for virtual workspaces, though apparently not workspaces with
    a package in the root dir
@triska
Copy link
Contributor

triska commented Mar 2, 2021

Thank you! However, does this once again break all external links to library files that occur in existing blog posts, tweets, emails, discussions etc. which point to the source files of Scryer Prolog on github, and which also occur in the README.md file of Scryer itself?

Please aim for a suitable balance between progress and breakage. If at all possible, I would prefer existing links to source files to keep working. If that is not possible, maybe it can at least be set up in such a way that the paths remain more stable in the future. The most recent such breakage occurred less than a year ago in 33325f1.

@Skgland
Copy link
Contributor Author

Skgland commented Mar 2, 2021

Does this once again break all external links to library files that occur in existing blog posts, tweets, emails, discussions etc. which point to the source files of Scryer Prolog on github?

Oh, I hadn't considered link breakage.
Unless permanent links to a specific commit where used this will likely break links. Github may be smart with redirects if the original file is not re-created like it is with project/user renames, but I couldn't find anything like that having been documented.

Please aim for a suitable balance between progress and breakage. If at all possible, I would prefer existing links to source files to keep working. If that is not possible, maybe it can at least be set up in such a way that the paths remain more stable in the future.

I am not sure what future breakage you have in mind. Though I would assume the paths to be stable unless one would move back to not use a virtual workspace or change the workspace layout.

It appears that most Issues regarding --no-default-features and --features in conjunction with workspaces have been closed now that the flags work with virtual workspaces. It may be that workspaces with a root package where overlooked. rust-lang/cargo#7160 is still open, though somewhat stale and the comment that the now stabilized feature should solve it is apparently false.

@Skgland Skgland closed this Mar 2, 2021
@Skgland Skgland reopened this Mar 2, 2021
@Skgland
Copy link
Contributor Author

Skgland commented Mar 3, 2021

I have found a workaround that is less disruptive, will open it in a separate pr

@Skgland Skgland closed this Mar 3, 2021
@triska
Copy link
Contributor

triska commented Mar 3, 2021

Thank you a lot!

@Skgland Skgland deleted the fix_num_test branch November 1, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants